[feat/basic-auth] password encryption #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
force-pushed
the
feature/basic-auth-sha1
branch
2 times, most recently
from
e2df105
to
738e1d7
Compare
thibaultcha
force-pushed
the
feature/basic-auth-sha1
branch
from
738e1d7
to
8c253cb
Compare
thibaultcha
force-pushed
the
feature/basic-auth-sha1
branch
from
11cd6e6
to
cdc7ad4
Compare
On the contrary of #527, this only allows for sha1 encryption. The reason is that due to the current architecture, we cannot support two types at the same time (supporting plain is a bad practice anyways). Because a basicauth_credential has no relation to a plugin entity (they are **not** semantically related anyways), we cannot now how the password is stored/encrypted. I also took the opportunity of 0.5.0 and the migration script to make that decision. The migration script will be updated to also migrate the current passwords. This does a bit more than #527: - unit tests - support encryption in unit test mode (with a mock using a vendor sha1 library) - comparison of the hash at the proxy level (for actual authentication) Resolves #33
thibaultcha
force-pushed
the
feature/basic-auth-sha1
branch
from
cdc7ad4
to
1d4c72e
Compare
thibaultcha
force-pushed
the
feature/basic-auth-sha1
branch
from
1d4c72e
to
c3eb1f2
Compare
thibaultcha
added
pr/ready (but hold merge)
thibaultcha
added a commit
that referenced
this pull request
Sep 21, 2015
[feat/basic-auth] password encryption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the contrary of #527, this only allows for sha1 encryption. The
reason is that due to the current architecture, we cannot support two
types at the same time (supporting plain is a bad practice anyways).
Because a basicauth_credential has no relation to a plugin entity (they
are not semantically related anyways), we cannot now how the
password is stored/encrypted.
I also took the opportunity of 0.5.0 and the migration script to make
that decision. The migration script will be updated to also migrate the
current passwords.
This does a bit more than #527:
library)
Resolves #33