[feature] IP Restriction Plugin #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subnetmarco
added
the
pr/ready (but hold merge)
subnetmarco
force-pushed
the
feature/ip-restriction
branch
2 times, most recently
from
a1e161d
to
86d7986
Compare
sonicaghi
added
the
idea/new plugin
subnetmarco
force-pushed
the
feature/ip-restriction
branch
2 times, most recently
from
72eea15
to
365db80
Compare
| @@ -420,7 +420,7 @@ local function fix_tables(t, old_t, schema) | |||
| if v.schema then | |||
| local s = type(v.schema) == "function" and v.schema(t) or v.schema | |||
| for s_k, s_v in pairs(s.fields) do | |||
| if not t[k][s_k] and old_t[k] then | |||
| if t[k] and not t[k][s_k] and old_t[k] then | |||
There was a problem hiding this comment.
Shouldn't this go 2 lines above?
if t[k] ~= nil and v.schema then -- explicit ~= nil is especially important in those cases too.
--
end
subnetmarco
force-pushed
the
feature/ip-restriction
branch
from
e382bbd
to
d41dfe9
Compare
subnetmarco
force-pushed
the
feature/ip-restriction
branch
from
b4887c0
to
ac5504b
Compare
subnetmarco
added a commit
that referenced
this pull request
Jul 10, 2015
[feature] IP Restriction Plugin
ctranxuan
pushed a commit
to streamdataio/kong
that referenced
this pull request
Aug 25, 2015
[feature] IP Restriction Plugin Former-commit-id: 2d31762b7f8ebabaad6820ddb92ed14f858eeba4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #379. Adds a very basic security plugin, that blocks incoming requests per IP.
Both individual IPs and ranges in CIDR notation (like
127.0.0.0/24) can be either whitelisted or blacklisted.It also fixes a few bugs like:
nilexception in DAO when updating a value that doesn't exist in a schema with aPATCHrequestPATCHupdate, setting anarrayfield to an empty value properly initializes an empty table{}instead of{""}