Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(router): remove duplicated reload_router() #13693

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

tests(router): remove duplicated reload_router() #13693

wants to merge 8 commits into from
+86 −213

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Sep 19, 2024 •
edited
Loading

Summary

KAG-5423

Separate setenv/unsetenv from misc to sys, then they will not depend on intenal.constants.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Sep 19, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 19, 2024
@chronolaw chronolaw marked this pull request as ready for review September 19, 2024 07:49
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 19, 2024
@chronolaw chronolaw removed the author/community PRs from the open-source community (not Kong Inc) label Sep 19, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chronolaw chronolaw

Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/L skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chronolaw @team-gateway-bot