Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gui): added a new feature to support multiple domains for gui. #13664

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raoxiaoyan
Copy link
Contributor

@raoxiaoyan raoxiaoyan commented Sep 13, 2024

Summary

  1. By default, set the origin retrieved from the request header or '*'.
  2. If the admin_gui_url has more than one domain, the origin from the request header must match one of the admin_gui_url. Otherwise, It can't access the Admin API via the Kong Manager.
    For example:
    admin_gui_url=http://example.com,http://km.konghq.com/manager
    These addresses access Kong Manager works well. http://example.com and http://km.konghq.com/manager.
    Others can't.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KM-516

Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort. Let's decide the optimal way to implement this feature before going deep into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/admin-api core/configuration size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants