Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataplane): add ExternalTrafficPolicy to ServiceOptions #241

Merged

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented May 6, 2024

What this PR does / why we need it:

Add ExternalTrafficPolicy to ServiceOptions.

Which issue this PR fixes

Part of #231

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@pmalek pmalek added this to the KGO v1.3.x milestone May 6, 2024
@pmalek pmalek self-assigned this May 6, 2024
@pmalek pmalek force-pushed the add-external-traffic-policy-to-dataplanes-service-options branch 2 times, most recently from 99750f7 to 594f3f4 Compare May 8, 2024 11:32
@pmalek pmalek force-pushed the add-external-traffic-policy-to-dataplanes-service-options branch from 594f3f4 to bdd6429 Compare May 8, 2024 11:47
@pmalek pmalek marked this pull request as ready for review May 10, 2024 09:55
@pmalek pmalek requested a review from a team as a code owner May 10, 2024 09:55
@rainest rainest merged commit 395c874 into main May 13, 2024
14 checks passed
@rainest rainest deleted the add-external-traffic-policy-to-dataplanes-service-options branch May 13, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants