Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the bundle configuration parser and bootstraps the extension that will automatically create services based on the provided configuration.
The configuration allows to configure one or multiple backends with the following parameters:
The above configuration will expose two services named
snappy.my_first_backend
andsnappy.my_second_backend
plus (potentially) all their variations for inputs and outputs.The available parameters are the following:
wkhtmltopdf
andchromium
Users will also be able to configure multiple backends of the same type, with different configurations.
In case we will like to support other backends that are not binary based we will add another configuration type more suited to them.
Does that work for you?
Note: in this PR I also fixed the CI workflow.