-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filament_motion_sensor: Add time-based runout calculation #4540
Conversation
Add optional time-based runout calculation to filament motion sensors. This is an alternate calculation method for detecting runout and jams and addresses problems that can occur with some motion sensors like the BTT sensor. Timeout mode is disabled by default. Signed-off-by: Mike Kershaw <dragorn@kismetwireless.net>
Clean up line lengths to make the linter happy Signed-off-by: Mike Kershaw <dragorn@kismetwireless.net>
Linter was unhappy with a space; removed. Signed-off-by: Mike Kershaw <dragorn@kismetwireless.net>
Fix initial timing state to prevent false timing positives during the homing/heatup state. Add an optional parameter to delay arming of the filament sensor for a configurable time at the start of printing for sensors which still incorrectly trigger. Signed-off-by: Mike Kershaw <dragorn@kismetwireless.net>
Appease extremely picky linter about white space after commas Signed-off-by: Mike Kershaw <dragorn@kismetwireless.net>
Thanks, however I'm not sure I understand what this does differently and what the intended audience is. How would a user set these new config options? Is there a way to tweak the existing config (and/or existing code) so that the hardware works reliably without adding new config options? @TheJoshW - do you have any comments? -Kevin |
Thanks, however I'm not sure I understand what this does differently and what the intended audience is.
This treats a pulse-based motion sensor as a timer rather than a distance sensor.
The intended audience is anyone with a pulse-style (instead of presence-style single switch) sensor which does not accurately report distance.
After inquiring on the discord server if anyone has successfully gotten the BTT "smart sensor" to work with the length estimation, I got several replies that it wasn't just me.
How would a user set these new config options?
Not sure I understand - the same way they set any other options? The filament motion sensor can either be monitored via estimated distance, which doesn't seem to work with some sensors like the BTT smartsensor, or by time, which has worked now for weeks with my tests.
Is there a way to tweak the existing config (and/or existing code) so that the hardware works reliably without adding new config options?
It would appear the BTT smartsensors aren't reliable in their distance reporting, since it constantly flags an underrun/jam.
This alternate movement indicator offers a way to make them function.
|
@dragorn for me the BTT sensor is working as is today. What I needed to do was switch it off while doing load or unload. |
***@***.***(https://github.com/dragorn) for me the BTT sensor is working as is today. What I needed to do was switch it off while doing load or unload.
I've tested 3 on 2 different printers; none of them consistently work in length mode. The faults happen anywhere from 5 minutes to multiple hours into printing, unrelated to load/unload cycles.
|
Hi @dragorn , are you able to describe the exact issue you are having? I am also trying to track down a random runout issue, however mine only occurs on the second print, never on the first (no matter how long the first print is). I have been avoiding it by restarting everything between prints until I can figure it out. I have made a change (attached) based on Kevin's original query here: #3857 (comment). I also updated get_status() to output additional useful info. I haven't seen any issues since these changes, however I haven't been printing much lately, so if you have a chance could you try running it for me and let me know the status values if you do get a false trigger. |
It looks like this GitHub Pull Request has become inactive. If there are any further updates, you can add a comment here or open a new ticket. Best regards, PS: I'm just an automated script, not a human being. |
Add optional time-based runout calculation to filament motion sensors.
This is an alternate calculation method for detecting runout and jams
and addresses problems that can occur with some motion sensors like the
BTT sensor.
Timeout mode is disabled by default.
Signed-off-by: Mike Kershaw dragorn@kismetwireless.net