Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filament_motion_sensor: Add time-based runout calculation #4540

Closed
wants to merge 5 commits into from

Conversation

dragorn
Copy link

@dragorn dragorn commented Jul 28, 2021

Add optional time-based runout calculation to filament motion sensors.
This is an alternate calculation method for detecting runout and jams
and addresses problems that can occur with some motion sensors like the
BTT sensor.

Timeout mode is disabled by default.

Signed-off-by: Mike Kershaw dragorn@kismetwireless.net

Add optional time-based runout calculation to filament motion sensors.
This is an alternate calculation method for detecting runout and jams
and addresses problems that can occur with some motion sensors like the
BTT sensor.

Timeout mode is disabled by default.

Signed-off-by: Mike Kershaw <dragorn@kismetwireless.net>
Clean up line lengths to make the linter happy

Signed-off-by: Mike Kershaw <dragorn@kismetwireless.net>
Linter was unhappy with a space; removed.

Signed-off-by: Mike Kershaw <dragorn@kismetwireless.net>
Fix initial timing state to prevent false timing positives during
the homing/heatup state.

Add an optional parameter to delay arming of the filament sensor for
a configurable time at the start of printing for sensors which still
incorrectly trigger.

Signed-off-by:  Mike Kershaw <dragorn@kismetwireless.net>
Appease extremely picky linter about white space after commas

Signed-off-by: Mike Kershaw <dragorn@kismetwireless.net>
@KevinOConnor
Copy link
Collaborator

Thanks, however I'm not sure I understand what this does differently and what the intended audience is. How would a user set these new config options? Is there a way to tweak the existing config (and/or existing code) so that the hardware works reliably without adding new config options?

@TheJoshW - do you have any comments?

-Kevin

@dragorn
Copy link
Author

dragorn commented Aug 17, 2021 via email

@zellneralex
Copy link
Contributor

@dragorn for me the BTT sensor is working as is today. What I needed to do was switch it off while doing load or unload.

@dragorn
Copy link
Author

dragorn commented Aug 17, 2021 via email

@TheJoshW
Copy link
Contributor

Hi @dragorn , are you able to describe the exact issue you are having? I am also trying to track down a random runout issue, however mine only occurs on the second print, never on the first (no matter how long the first print is). I have been avoiding it by restarting everything between prints until I can figure it out. I have made a change (attached) based on Kevin's original query here: #3857 (comment). I also updated get_status() to output additional useful info. I haven't seen any issues since these changes, however I haven't been printing much lately, so if you have a chance could you try running it for me and let me know the status values if you do get a false trigger.
Thanks.
filament_motion_sensor.py.txt

@KevinOConnor KevinOConnor added the pending feedback Topic is pending feedback from submitter label Aug 24, 2021
@github-actions
Copy link

It looks like this GitHub Pull Request has become inactive. If there are any further updates, you can add a comment here or open a new ticket.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@github-actions github-actions bot added the inactive Not currently being worked on label Sep 20, 2021
@github-actions github-actions bot closed this Sep 20, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
inactive Not currently being worked on pending feedback Topic is pending feedback from submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants