-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tifffile>=2023.4.12 in requirements.txt #66
Conversation
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
The bad version appears to have been I'm tempted to try testing against several versions of Feel free to ignore the Python3.9 failure (will be addressed in #65). |
I was just told by a colleague @mdotter-mitre that even version |
It looks like from |
Thanks for pointing this out. I'm reluctant to break backwards compatibility (recent versions of
Do we know for certain that the regression was introduced in |
Thanks for looking into this. I'll check it out when I'm up (Aus time). @Zeitsperre I'll give you ownership of this repo and the PyPI so you can update at will. Also, looks like mypy is failing in version in 3.9. |
@KipCrossing Thanks so much! My PyPI username is the same as on here. I'll do my best to not make any egregious packaging errors! AFAIK, the mypy error is addressed here: fa6598c |
@doyled-it do you mind pulling the latest main into this branch? |
@Zeitsperre I've added you to PyPI. Is there any additional permissions that you need here on GitHub so, if I'm AFK for a while you can do everything? In general, it would be good to get more contributes on this project. The UI is pretty ugly and could use an overhaul. I'm not really in the GIS space these days so I don't have any strong opinions, tho. (sorry for dumping this in the PR haha) |
@KipCrossing I'm kinda new to GitHub PRs and forking as we mostly work with GitLab MRs, so I hope I did that correct here. |
Perfect! I'll merge to main and fix the typing problem before deploying to PyPI |
Closes #62
I ran the code in #62 with this
tifffile
version installed and I received the same output.