Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tifffile>=2023.4.12 in requirements.txt #66

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

doyled-it
Copy link
Contributor

Closes #62

I ran the code in #62 with this tifffile version installed and I received the same output.

requirements.txt Outdated Show resolved Hide resolved
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@Zeitsperre
Copy link
Collaborator

Zeitsperre commented Aug 22, 2023

The bad version appears to have been tifffile@v2022.4.26. I'll need to go through the changelogs here and there to figure out what we should be pinning.

I'm tempted to try testing against several versions of tiffile to see exactly which versions should be avoided.

Feel free to ignore the Python3.9 failure (will be addressed in #65).

@doyled-it
Copy link
Contributor Author

doyled-it commented Aug 22, 2023

The bad version appears to have been tifffile@v2022.4.26. I'll need to go through the changelogs here and there to figure out what we should be pinning.

I'm tempted to try testing against several versions of tiffile to see exactly which versions should be avoided.

Feel free to ignore the Python3.9 failure (will be addressed in #65).

I was just told by a colleague @mdotter-mitre that even version 2023.3.21 of tifffile produces the same error, so yeah, it may require going through more versions.

@mdotter-mitre
Copy link

mdotter-mitre commented Aug 22, 2023

It looks like from this issue, any version below and including tifffile<=2023.3.21 will result on the NODATA error, not isolated in tifffile==2022.4.26. Recommend setting tifffile>=2023.4.12.

@Zeitsperre
Copy link
Collaborator

Zeitsperre commented Aug 22, 2023

@doyled-it @mdotter-mitre

Thanks for pointing this out.

I'm reluctant to break backwards compatibility (recent versions of tifffile drop both Python3.7 and 3.8), so maybe we can make use of PEP 508's environment markers, i.e.

tifffile>=2021.7.4,<the.version.where.it.all.went.wrong;python_version>=3.7,<3.9
tifffile>=2023.4.12;python_version>=3.9

Do we know for certain that the regression was introduced in tifffile==2022.4.26, or did it happen earlier?

@KipCrossing
Copy link
Owner

Thanks for looking into this. I'll check it out when I'm up (Aus time).

@Zeitsperre I'll give you ownership of this repo and the PyPI so you can update at will.


Also, looks like mypy is failing in version in 3.9.

@Zeitsperre
Copy link
Collaborator

Zeitsperre commented Aug 22, 2023

@KipCrossing Thanks so much! My PyPI username is the same as on here. I'll do my best to not make any egregious packaging errors!

AFAIK, the mypy error is addressed here: fa6598c

@KipCrossing
Copy link
Owner

@doyled-it do you mind pulling the latest main into this branch?

@KipCrossing
Copy link
Owner

@Zeitsperre I've added you to PyPI. Is there any additional permissions that you need here on GitHub so, if I'm AFK for a while you can do everything?


In general, it would be good to get more contributes on this project. The UI is pretty ugly and could use an overhaul. I'm not really in the GIS space these days so I don't have any strong opinions, tho.

(sorry for dumping this in the PR haha)

@doyled-it
Copy link
Contributor Author

doyled-it commented Aug 22, 2023

@doyled-it do you mind pulling the latest main into this branch?

@KipCrossing I'm kinda new to GitHub PRs and forking as we mostly work with GitLab MRs, so I hope I did that correct here.

@KipCrossing
Copy link
Owner

@KipCrossing I'm kinda new to GitHub PRs and forking as we mostly work with GitLab MRs, so I hope I did that correct here.

Perfect! I'll merge to main and fix the typing problem before deploying to PyPI

@KipCrossing KipCrossing merged commit 5c432bc into KipCrossing:main Aug 23, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeoTIFFs not being loaded with tifffile 2022.4.26
4 participants