Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR should speed up the
GeoTiff.get_coord_arrays
method by several orders of magnitude for any larger array.The previous implementation spent a lot of time, calling
TifTransformer.get_xy
for every grid node seperately. Solved by adding a methodTifTransformer.get_xy_array
to do the transform for all requested nodes in a single shot and letting numpy do the looping.Sorry, I couldn't run pre-commit locally because it fails when setting up the various dependencies with pip. I cannot investigate the reason due to time constraints.
The proposed changes break some internal interfaces (
_convert_coords_array
now takes arrays instead of lists), therefore I label this as WIP. Please check if this is a problem.Best wishes
Sebastian