Adamfuller zz patch 1 #29
Conversation
In the event that geotiff_metadata["ProjectedCSTypeGeoKey"] is already an int e.g. 2193 from https://koordinates.com/layer/3741-14-palmerston-north-15m-dem-nzsosdem-v10/
geotiff/geotiff.py
Outdated
| temp_crs_code = geotiff_metadata["ProjectedCSTypeGeoKey"].value | ||
| if hasattr(geotiff_metadata["ProjectedCSTypeGeoKey"], 'value'): | ||
| temp_crs_code = geotiff_metadata["ProjectedCSTypeGeoKey"].value | ||
| else |
There was a problem hiding this comment.
@adamfuller-zz Looks like you left out a : on your else statement
|
You can test your changes by running: You may need to install |
|
God not a great first outing. Yep I thought I would be clever and make my commit through the github web editor without actually running the code (or using pytest, I'd never used it but I installed it and have run it successfully now yay). Unfortunately for geotiff, this is the first public repo I have contributed to, your karma is definately +1 now. |
All good. A great way to learn is to make mistakes - especially in a public setting. I welcome all patches as it's impossible for me to know about all the edge cases; such as this one. Thanks for the PR |
|
The new version it up the your fix: https://pypi.org/project/geotiff/0.2.3/ |
Hi Kip, I wound up closing my original PR and creating this new one.