MLIBZ-2323: Thrown error in onNext() in observable causes silent observable unsubscribe #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -128,7 +128,7 @@ class SafeSubscriber extends Subscriber { | |||
| try { | |||
| fn.call(this._context, value); | |||
| } catch (err) { | |||
| this.unsubscribe(); | |||
| this.error(err); | |||
There was a problem hiding this comment.
Makes sense to throw an error here. But are there certain cases where we should still unsubscribe, or is this now something the developer should handle completely?
There was a problem hiding this comment.
It will still unsubscribe after the error callback is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an error in the onNext() function is thrown, the error is silently handled by the SDK and an unsubscribe from the observable is called, thus leaving the developer without notification that something went wrong.
A running sample describing the above can be found here. Without a try-catch block, trying to access a property from the returned entities will cause an error as the first fetched result would be from the localStorage and thus an empty array. The thrown error will not be shown to the developer causing a silent unsubscribe from the observable.
Changes
onNext()function for an ObservableTests
onNext()function