Added deltaset tests #294
Merged
Added deltaset tests #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasconner
approved these changes
May 10, 2018
Martin-Hristov
force-pushed
the
mhristov/deltaset-integration-tests
branch
from
6a59baf
to
575b3a3
Compare
Martin-Hristov
force-pushed
the
mhristov/deltaset-integration-tests
branch
from
575b3a3
to
d29b076
Compare
thomasconner
force-pushed
the
mhristov/deltaset-integration-tests
branch
from
45cf5a3
to
f5080c6
Compare
added 2 commits
May 18, 2018 19:11
thomasconner
added a commit
that referenced
this pull request
May 18, 2018
* MLIBZ-2316: Delete deltaFetch.js * MLIBZ-2316: Add deltaset.js * MLIBZ-2316: Remove export of deltaFetch * MLIBZ-2316: Use new deltaSet function in NetworkRepository * Remove TODO comment * MLIBZ-2316: Add clearDeltaSet function * MLIBZ-2316: Add tests for using delta set with a CacheStore * MLIBZ-2316: Rename useDeltaFetch to useDeltaSet * MLIBZ-2316: Add delta set constants * MLIBZ-2316: Split delta set logic into smaller functions * MLIBZ-2316: Add tests for delta set * Update package versions to 3.10.1-beta.1 * Make requested changes from code review for delta set * Don't perform _replaceOfflineEntities() when using delta set * Fix typo and change name from xKinveyRequestStartHeader to kinveyRequestStartHeader * Don't duplicate function calls in SyncManager.pull() * Fix check for if statment for SyncManager.pull() * Only replace entities if useDeltaSet is not true * Default options to an empty object in SyncManager.pull() * Fix failing unit tests related to changes * Add checks for skip amd limit modifiers to delta set * MLIBZ-2316: Handle skip and limit for Delta Set We will log that the skip and limit modifiers will be ignored for a delta set request. These modifiers will be appliead to the cache after the delta set request has completed. A find() and pull() on a data store will now honor skip and limit modifiers preventing the user from keeping track of when they can and cannot use a specific query. * Update logged message for delta set * Use original query when performing regular GET request for delta set * MLIBZ-2316: Send a regular GET request if a query contains a skip and/or limit modifier * MLIBZ-2437: Send a regular GET request if a ParamaterValueOutOfRangeError is received from a delta set request * Add missing curly brace * Fixing failing tests * Add InvalidCachedQuery error * Export InvalidCachedQuery error * Add querycache.js * Add a getter for X-Kinvey-Request-Start header to Headers class * Remove constants * Refactor SyncManager to use new deltaset and querycache files * Use requestStart getter from headers * Fix failing unit tests * Bug fixes for Delta Set * Fix some bugs found during testing * Fix skipped unit tests * MLIBZ-2478: Return count of items changed when making a _deltaset request with pull() * MLIBZ-2477: Handle NotFoundError when deleting a cachedQuery * MLIBZ-2486: Ignore limit and skip for auto pagination and update tests * MLIBZ-2493: Perform delta set delete and then delta set changed serially instead of in parallel. * MLIBZ-2449: Do not filter out _QueryCache table or __testSupport__ table when get all tables for WebSQL * MLIBZ-2495: Ignore deleting entities when limit and skip are used to pull entities * Update _queryCache after auto pagination has completed * MLIBZ-2512: Ignore skip value of query for auto pagination * Fix failing unit test that checks if skip is ignored for auto pagination * Added deltaset tests (#294) * Added deltaset tests * added new tests for limit and skip and some unit tests * skipped tests that use websql to not run on other than html5 and removed a .only * removed another .only * did some refactoring and fixed tests failing for Nativescript and Phonegap * Fix status code set with nock for failing unit test * Added deltaset tests * added new tests for limit and skip and some unit tests * skipped tests that use websql to not run on other than html5 and removed a .only * removed another .only * did some refactoring and fixed tests failing for Nativescript and Phonegap * Fix status code set with nock for failing unit test * added a test for autopagination with skip and limit * fixing an expectation string and wrong expectation for deltaset test * Added deltaset tests * added new tests for limit and skip and some unit tests * skipped tests that use websql to not run on other than html5 and removed a .only * removed another .only * did some refactoring and fixed tests failing for Nativescript and Phonegap * Fix status code set with nock for failing unit test * removed .only again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding integration tests for deltaset