Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLIBZ-2422: Validate MIC RedirectUri #283

Merged
merged 2 commits into from
Apr 25, 2018
Merged

MLIBZ-2422: Validate MIC RedirectUri #283

merged 2 commits into from
Apr 25, 2018

Conversation

thomasconner
Copy link
Contributor

Description

Adds validation that checks if a redirectUri provided to mic.login() is provided and a string.

Changes

  • Return a rejected Promise if the redirectUri provided to mic.login() is invalid.

Tests

  • Added a test that checks that mic.login() fails when no redirectUri is provided.
  • Added a test that checks that mic.login() fails when redirectUri is not a string.

@thomasconner thomasconner self-assigned this Apr 6, 2018
tejasranade
tejasranade approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@tejasranade tejasranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasconner thomasconner merged commit 0fb8c64 into master Apr 25, 2018
@thomasconner thomasconner deleted the MLIBZ-2422_Validate_MIC_-RedirectUri branch April 25, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejasranade tejasranade tejasranade approved these changes

Assignees

@thomasconner thomasconner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasconner @tejasranade