Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for loginWithMIC for the HTML5 Shim #279

Merged
merged 62 commits into from
Mar 29, 2018
Merged

Added tests for loginWithMIC for the HTML5 Shim #279

merged 62 commits into from
Mar 29, 2018

Conversation

tsvetomir-nedyalkov
Copy link
Contributor

Description

Added tests for loginWithMIC for HTML5 Shim with an OAuth 2 provider (Facebook)

Changes

  1. Added the tests for loginWithMIC
  2. Encrypted in Travis all sensitive variables (including the Facebook user credentials). I will prepare an additional document, which describes how to execute the tests locally
  3. Added User collection cleanup before the tests execution
  4. Added some Chrome flags in webRunTests.js in order to be able to handle the Facebook popup
  5. Small fix for the empty array verification in sync tests

@tsvetomir-nedyalkov
Test commit
21ef185
@tsvetomir-nedyalkov
Changes to test mic test on ubuntu
3d04d81
@tsvetomir-nedyalkov
Reverted a change
3415e52
@tsvetomir-nedyalkov
Added --disable-popup-blocking
527aa6d
@tsvetomir-nedyalkov
Reverted the changes for ubuntu
0791066
@tsvetomir-nedyalkov
added --user-data-dir option
bd5d518
@tsvetomir-nedyalkov
Left only html5 integration tests in travis.yml
709d395
@tsvetomir-nedyalkov
Added two flags
5a06536
@tsvetomir-nedyalkov
Removed use-data-dir
ecb3f84
@tsvetomir-nedyalkov
Try with dist: precise
7ec0947
@tsvetomir-nedyalkov
reverted to dist trusty
55f5d4e
@tsvetomir-nedyalkov
Changed the pass value to an invalid one
cbaa7cc
@tsvetomir-nedyalkov
Test clear of FB cookies
4e51f88
@tsvetomir-nedyalkov
Reverted common-crud tests changes and added MIC tests only for HTML5
0f9b70e
@tsvetomir-nedyalkov
Refactoring of the tests structure
c0a7213
@tsvetomir-nedyalkov
Small refactoring of some variables
73d2b4a
@tsvetomir-nedyalkov
Fixed the first test for login
0adb23c
@tsvetomir-nedyalkov
Moved the logout to the beforeEach hook
393606b
@tsvetomir-nedyalkov
Added one more test with specified auth service id
81d5a74
@tsvetomir-nedyalkov
Small refactoring plus skipping one test
4140891
@tsvetomir-nedyalkov
Added a test for cancelled login
8ac7a55
@tsvetomir-nedyalkov
Added user deletion
207c377
@tsvetomir-nedyalkov
Merge branch 'master' into QA-176_mic_tests
68fe067
@tsvetomir-nedyalkov
Added back a skipped test
fb5b972
@tsvetomir-nedyalkov
Small fix for the refresh_token verification
f219424
@tsvetomir-nedyalkov
Added a test for expired access_token refresh
735ac0f
@tsvetomir-nedyalkov
Small refactoring
8c41222
@tsvetomir-nedyalkov
Changed ttl as there were some random failures
62b64e0
@tsvetomir-nedyalkov
Added some comments
9be61db
@tsvetomir-nedyalkov
Renamed loginFacebook function
97e831d
@tsvetomir-nedyalkov
Temporary changing the HTML5 tests app
63296aa
@tsvetomir-nedyalkov
Added tests for options.version
6a0c282
@tsvetomir-nedyalkov
Added one test for loginWithMic when there is an existing Active User
dfba884
@tsvetomir-nedyalkov
Added an additional verification
5c15643
@tsvetomir-nedyalkov
Small refactoring
585f47c
@tsvetomir-nedyalkov
Small refactor
c51c962
@tsvetomir-nedyalkov
Fixed the array check, because it did not fail if the result is not a…
fe23d71 
…n array
@tsvetomir-nedyalkov
Added some variables for error messages
3756b05
@tsvetomir-nedyalkov
Added a serveHost variable
a827a0e
@tsvetomir-nedyalkov
Added a separate function addCloseFacebookPopupHandler
9f04b33
@tsvetomir-nedyalkov
Added a separate function for the popup url validation
40659ca
@tsvetomir-nedyalkov
Removed a not needed variable
ec28523
@tsvetomir-nedyalkov
Small refactoring
692dd2a
@tsvetomir-nedyalkov
Added a resolveAfter function
118dc2a
@tsvetomir-nedyalkov
Pointed the HTML5 tests to the correct app
6f0e0d8
@tsvetomir-nedyalkov
Added back all jobs in the travis.yml
9c4e810
@tsvetomir-nedyalkov
Change the auth service id
ceda717
@tsvetomir-nedyalkov
Temporary commit - executing the integration tests on push
92b3eee
@tsvetomir-nedyalkov
Revert "Temporary commit - executing the integration tests on push"
5e3385d 
This reverts commit 92b3eee.
@tsvetomir-nedyalkov
Added authServiceId in tests-config.js
bb24685
@tsvetomir-nedyalkov
Merge branch 'master' into QA-176_mic_tests
566ad5e
@tsvetomir-nedyalkov
Removed a new line
8fbd559
@tsvetomir-nedyalkov tsvetomir-nedyalkov changed the title Added tests for loginWithMIC tests for the HTML5 Shim Added tests for loginWithMIC for the HTML5 Shim Mar 27, 2018
@tsvetomir-nedyalkov tsvetomir-nedyalkov self-assigned this Mar 28, 2018
thomasconner
thomasconner reviewed Mar 29, 2018
View reviewed changes
.travis.yml
@@ -5,6 +5,23 @@ env:
- INTEGRATION_TESTS_CORDOVA_VERSION='8.0.0'
- UNIT_TESTS_NODEJS_VERSION='9'
- RUN_INTEGRATION_TESTS_FILE_LOCATION='./test/integration/run-tests'
- secure: IuywIkmD6t8wxh1OpjMgHvvGIzDBDXXahkhlTFsuxN0kowqlWrF9F1gCyMdg7dALJ+rtInISGIm+7UrTbyoNSBPHRkzXyU0p1eDx8shBLYOg8dKxTwUn61zb3ckOMt1sYwOy2x00d6MUIayB0uu5haYUyi4zt8bqs2Mp548oO4r5+Y4/Tnt3lP5/dGFyxOER7HZdb+Ka9KguzhgJeWSF7dRMjQCHCccUO4i2Gp6cQVE8xI2e9nN6SXDwuQrIq8zRcbCh/5sH4R1uEHEKDT5u0gBIN5eBQSkjG7rtBi3Vaif7TsSqRTGUV2njKCIO7Cd8HLHeY9D7WHFMsLXOGo2hGZvdaeq9QXoJ3mswNO0AUP6Smam+Bg8YeHy+x6+/yGIT7N0J0wrZUY3WeEpq3b14+f2YtDhhGS0m3K6uLllOQ+NVHvkgEEVp7y4pxJhTf8e9Gc6ZCoJOAY+NCjI7wnDQ0DbyanoE5JbhyL6oDv1P+sZE9Ixm3fRIZVrUf4g3P31AXL4O4UUdcTjMwUmTktweXGLCKqbtS/XepxtaeUTthacoTYALkjpgDeB3jrOLiEUxVjI2GYH4IRjdutAohVfgEFy8m5KiTdw5pQQFzT+u+T+YRf9N3o5O/BSSJuzpa57nmPa9ShCHNLLahEAVi65fRo1Ols7pU8ZnLxZ7r6PrrwQ=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are all these secure environment variables?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind I see where they are being used and what they represent.

@thomasconner
Copy link
Contributor

A good provider to test is Google. They have some strict requirements around the user-agent that is used. Just something that we could add. Good Job!

@tsvetomir-nedyalkov tsvetomir-nedyalkov merged commit 384c04f into master Mar 29, 2018
@tsvetomir-nedyalkov tsvetomir-nedyalkov deleted the QA-176_mic_tests branch March 29, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasconner thomasconner thomasconner approved these changes

Assignees

@tsvetomir-nedyalkov tsvetomir-nedyalkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsvetomir-nedyalkov @thomasconner