Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-1559: Increase Test Coverage #122

Merged
merged 19 commits into from
Apr 14, 2017
Merged

Conversation

thomasconner
Copy link
Contributor

Description

This PR increases the test coverage by adding tests.

Changes

  • Added tests to increase test coverage.
  • Fixed issues with Query class, sync, and data stores.

@thomasconner thomasconner self-assigned this Apr 5, 2017
@codecov-io
Copy link

codecov-io commented Apr 5, 2017

Codecov Report

Merging #122 into master will increase coverage by 9.05%.
The diff coverage is 94.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   81.27%   90.33%   +9.05%     
==========================================
  Files          78       77       -1     
  Lines        6501     6495       -6     
  Branches     1049     1045       -4     
==========================================
+ Hits         5284     5867     +583     
+ Misses       1217      628     -589
Impacted Files Coverage Δ
src/datastore/src/syncstore.js 93.33% <100%> (+19.45%) ⬆️
src/datastore/src/userstore.js 81.59% <100%> (+2.65%) ⬆️
...c/request/src/middleware/src/storage/src/memory.js 94.87% <100%> (-1.71%) ⬇️
src/kinvey.js 98.74% <100%> (ø) ⬆️
src/request/src/middleware/src/cache.js 100% <100%> (ø) ⬆️
src/datastore/src/sync.js 93.26% <100%> (+10.93%) ⬆️
src/utils/src/object.js 100% <100%> (+10.71%) ⬆️
src/errors/src/notFound.js 100% <100%> (ø) ⬆️
src/datastore/src/datastore.js 100% <100%> (+40.57%) ⬆️
src/request/src/network.js 92.11% <100%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2744c25...94ce37b. Read the comment docs.

Copy link
Contributor

@heyzooi heyzooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasconner thomasconner merged commit 94ce37b into master Apr 14, 2017
@thomasconner thomasconner deleted the MLIBZ-1559_test_coverage branch April 14, 2017 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants