Implement accessors for inner reader on StreamDecoder #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifd3f
force-pushed
the
access-inner-reader
branch
from
a279eaf
to
4b79cb9
Compare
ifd3f
force-pushed
the
access-inner-reader
branch
from
4b79cb9
to
0eb1c10
Compare
ifd3f
force-pushed
the
access-inner-reader
branch
from
0c6d3a5
to
057f710
Compare
|
Seems I forgot to run with --no-default-features, oops. |
No worries, I do that all the time. But that's what the CI is here for :) |
|
Don't worry about the clippy thing, I can fix that after merging. I'll do that later today 👍 Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an application where I access the inner Read object to get some statistics on how far we've read. This adds
get_refandget_mut, and another one where you can destructure to get both the Read and FrameDecoder.