-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation throughout the codebase. #61
Conversation
Very nice thanks! I'll give it a read soon. About the compressor side of things: I would definitely accept a very basic compressor. I toyed with the idea of implementing an encoder that only supports RAW and RLE blocks. Even a "bad" compressor would enable interoperability between software that is expected to exchange data in zstd frames. |
Hi just a few things to fix. Sorry for not making it one review I probably spammed your inbox a bit :/ I want to thank you again, that's a lot of good doc! |
All requested changes have been applied, there are a few things I think you should double check, but I've done everything you asked |
Looks good to me, the two CI errors should be easy fixes. The doc comment should be fixable by not making it a file but just creating a reader with a
|
Thanks! |
I wanted to see how feasible it would be to implement a compressor for this crate, so I went through the code and added documentation for most things. Whether or not I implement a compressor in the future will depend on my motivation, but at the very least, I can contribute doc improvements.