Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation throughout the codebase. #61

Merged
merged 5 commits into from
May 21, 2024

Conversation

zleyyij
Copy link
Contributor

@zleyyij zleyyij commented May 14, 2024

I wanted to see how feasible it would be to implement a compressor for this crate, so I went through the code and added documentation for most things. Whether or not I implement a compressor in the future will depend on my motivation, but at the very least, I can contribute doc improvements.

@KillingSpark
Copy link
Owner

Very nice thanks! I'll give it a read soon.

About the compressor side of things: I would definitely accept a very basic compressor. I toyed with the idea of implementing an encoder that only supports RAW and RLE blocks. Even a "bad" compressor would enable interoperability between software that is expected to exchange data in zstd frames.

src/blocks/block.rs Outdated Show resolved Hide resolved
src/blocks/block.rs Outdated Show resolved Hide resolved
src/frame.rs Outdated Show resolved Hide resolved
src/huff0/mod.rs Outdated Show resolved Hide resolved
@KillingSpark
Copy link
Owner

Hi just a few things to fix. Sorry for not making it one review I probably spammed your inbox a bit :/

I want to thank you again, that's a lot of good doc!

@zleyyij
Copy link
Contributor Author

zleyyij commented May 19, 2024

All requested changes have been applied, there are a few things I think you should double check, but I've done everything you asked

@zleyyij zleyyij requested a review from KillingSpark May 19, 2024 19:35
@KillingSpark
Copy link
Owner

KillingSpark commented May 20, 2024

Looks good to me, the two CI errors should be easy fixes.

The doc comment should be fixable by not making it a file but just creating a reader with a todo!()

let reader: &mut Read = todo!("Get a reader from somewhere, like a file");

@KillingSpark KillingSpark merged commit 0b96073 into KillingSpark:master May 21, 2024
2 checks passed
@KillingSpark
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants