Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for orders app #220

Merged
merged 14 commits into from
Apr 28, 2022
Merged

Added tests for orders app #220

merged 14 commits into from
Apr 28, 2022

Conversation

KiOui
Copy link
Owner

@KiOui KiOui commented Apr 2, 2022 •
edited
Loading

Added tests for orders app.

(And also some tests for the settings app).

@KiOui KiOui marked this pull request as draft April 2, 2022 14:31
@KiOui KiOui changed the title Added view tests for orders Added tests for orders app Apr 3, 2022
@KiOui KiOui marked this pull request as ready for review April 9, 2022 20:41
@KiOui KiOui requested a review from JobDoesburg April 10, 2022 07:52
@KiOui KiOui self-assigned this Apr 10, 2022
@KiOui KiOui added the testing label Apr 10, 2022
@KiOui
Copy link
Owner Author

KiOui commented Apr 10, 2022

First pull request with the testing label!

JobDoesburg
JobDoesburg requested changes Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@JobDoesburg JobDoesburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think code quality would improve by:

  • adding subTests
  • use assertRaises properly

pyproject.toml Outdated Show resolved Hide resolved
website/orders/models.py Outdated Show resolved Hide resolved
website/orders/models.py Outdated Show resolved Hide resolved
website/orders/models.py Show resolved Hide resolved
website/orders/models.py Outdated Show resolved Hide resolved
website/orders/tests/test_models.py Outdated Show resolved Hide resolved
website/orders/tests/test_models.py Outdated Show resolved Hide resolved
website/orders/tests/test_models.py Show resolved Hide resolved
website/orders/tests/test_models.py Outdated Show resolved Hide resolved
website/orders/tests/test_services.py Outdated Show resolved Hide resolved
@KiOui KiOui requested a review from JobDoesburg April 24, 2022 08:43
@JobDoesburg JobDoesburg merged commit 93d1831 into master Apr 28, 2022
@JobDoesburg JobDoesburg deleted the tests/orders-tests branch April 28, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JobDoesburg JobDoesburg Awaiting requested review from JobDoesburg

Assignees

@KiOui KiOui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KiOui @JobDoesburg