Added Django filter for API endpoints #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JobDoesburg
approved these changes
Mar 14, 2022
| let yearInThePast = now.getTime() - yearOffset; | ||
| let yearInTheFuture = now.getTime() + yearOffset; | ||
| let yearInThePastDate = new Date(yearInThePast); | ||
| let yearInTheFutureDate = new Date(yearInTheFuture); |
There was a problem hiding this comment.
I would refactor these variable names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added API query parameters to the following endpoints:
nameis now possible)nameandbarcodeis now possible), the oldProductSearchAPIViewendpoint has been deleted in favor of searching on the Products list endpoint. Javascript has also been fixed for the change in endpoint.venueis now possible, searching ondisplay_nameis now possible)can_be_reservedis now possible, searching onnameandslugis now possible)VenueReservationListAPIViewhas been deleted in favor of the normal Reservation list view with a query parameter (e.g. filtering onvenue). Also note that thedaysparameter for the Reservation list view has been deleted in favor ofstart__gteandstart__lte. Javascript has also been fixed for the change.In addition, the following bugs were fixed:
get_querysetof the ProductsListAPI was called when the schema was generated which raised a Warning.Closes #180