Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/dark mode #149

Merged
merged 4 commits into from
Feb 20, 2021
Merged

Feature/dark mode #149

merged 4 commits into from
Feb 20, 2021

Conversation

KiOui
Copy link
Owner

@KiOui KiOui commented Feb 20, 2021 •
edited
Loading

Added dark mode to the entire website with CSS variables.

Closes #40
Closes #10

@KiOui KiOui marked this pull request as draft February 20, 2021 19:53
@KiOui KiOui self-assigned this Feb 20, 2021
@KiOui
Copy link
Owner Author

KiOui commented Feb 20, 2021

Maybe we also need to make a dark mode for Swagger UI and the administration screen.

@JobDoesburg
Copy link
Collaborator

I like these colors!

@JobDoesburg
Copy link
Collaborator

Maybe we also need to make a dark mode for Swagger UI and the administration screen.

Lets not try the Django admin. I tried that in #concrexit and its a mess. For swaggerUI let's wait until I did #144

@KiOui KiOui marked this pull request as ready for review February 20, 2021 21:48
@KiOui KiOui merged commit 0b35745 into master Feb 20, 2021
@KiOui KiOui deleted the feature/dark-mode branch February 20, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JobDoesburg JobDoesburg JobDoesburg approved these changes

Assignees

@KiOui KiOui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: dark mode Use CSS variables
2 participants
@KiOui @JobDoesburg