Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced POST with data #140

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Replaced POST with data #140

merged 3 commits into from
Feb 17, 2021

Conversation

KiOui
Copy link
Owner

@KiOui KiOui commented Feb 17, 2021

Fixed an error where we consulted the POST attribute instead of data.

Closes #139

@KiOui KiOui added the bug Something isn't working. label Feb 17, 2021
@KiOui KiOui self-assigned this Feb 17, 2021
Copy link
Collaborator

@JobDoesburg JobDoesburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CustomAutoSchema does not work properly, could you verify it?
image
The track id should show as a parameter and there should be example responses as well

@KiOui
Copy link
Owner Author

KiOui commented Feb 17, 2021

This is a POST parameter and therefor it should be specified within the POST parameters (and thus the request body). The parameters that are specified under "Parameters" in SwaggerUI can only be query, header, path and cookie parameters (and thus not POST parameters). See here for more details (under Parameter object).

@JobDoesburg JobDoesburg merged commit 40e2cc2 into master Feb 17, 2021
@JobDoesburg JobDoesburg deleted the fix/track-add-endpoint branch February 17, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding tracks is broken (at least on swagger UI)
2 participants