Expose supercompression functions via JNI #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkCallow
requested changes
Mar 25, 2024
interface/java_binding/src/main/java/org/khronos/ktx/KtxTexture2.java
Outdated
Show resolved
Hide resolved
interface/java_binding/src/test/java/org/khronos/ktx/test/KtxTexture2Test.java
Outdated
Show resolved
Hide resolved
# Conflicts: # interface/java_binding/src/test/java/org/khronos/ktx/test/KtxTexture2Test.java
MarkCallow
reviewed
Mar 27, 2024
interface/java_binding/src/test/java/org/khronos/ktx/test/KtxTexture2Test.java
Outdated
Show resolved
Hide resolved
|
@javagl I will be away from Thursday morning for 10 days. If you can make the requested changes and merge the changes from main before 22:00 JST (13:00 UTC) today I can merge before I leave otherwise it will have to wait. |
As I just mentioned in #876 (comment) : It's not time-critical. There are different options for the merge order. And merge conflicts are unlikely. So we don't have to do anything hastily. I'll try to fix the test for the swizzle PR, wrap up this one, and then continue with the 'JNI improvements' one, and we can talk about the merging details when you are back. |
…ssion # Conflicts: # interface/java_binding/src/test/java/org/khronos/ktx/test/KtxTexture2Test.java
MarkCallow
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated:
This builds upon #876 , which is already merged.
It exposes the
deflateZstdanddeflateZLIBfunctions of thektxTexture2class to the JavaKtxTexture2class.This is only a tiny part of the changes that are contained in #886 , but could be merged independently.