libktx: update ktxTexture2_setImageFromStream to allow setting the entire level's data in one call #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MarkCallow
requested changes
Nov 3, 2023
lib/writer2.c
Outdated
| return result; | ||
|
|
||
| imageByteLength = ktxTexture_GetImageSize(ktxTexture(This), level); | ||
| if (faceSlice == (ktx_uint32_t)(-1)) { |
There was a problem hiding this comment.
Since this does not change the type of the faceSlice parameter, which I agree with, let's document this as specify UINT_MAX (i.e. the value of -1 cast to uint32_t) instead of -1 to set the entire level. Consider making a define to be used, e.g. KTX_ENTIRE_LEVEL.
There was a problem hiding this comment.
done, I did it that way to avoid including limits.h
…tire level's data in one call Fixes: KhronosGroup#792
MarkCallow
approved these changes
Nov 4, 2023
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 21, 2024
…tire level's data in one call (KhronosGroup#794) This change updates `ktxTexture2_setImageFromStream` to allow setting `faceSlice` to `KTX_FACESLICE_WHOLE_LEVEL`. This allows setting the entire level's data in one call rather having to do a loop setting each slice individually. Fixes: KhronosGroup#792
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
…tire level's data in one call (KhronosGroup#794) This change updates `ktxTexture2_setImageFromStream` to allow setting `faceSlice` to `KTX_FACESLICE_WHOLE_LEVEL`. This allows setting the entire level's data in one call rather having to do a loop setting each slice individually. Fixes: KhronosGroup#792
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
…tire level's data in one call (KhronosGroup#794) This change updates `ktxTexture2_setImageFromStream` to allow setting `faceSlice` to `KTX_FACESLICE_WHOLE_LEVEL`. This allows setting the entire level's data in one call rather having to do a loop setting each slice individually. Fixes: KhronosGroup#792
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
…tire level's data in one call (KhronosGroup#794) This change updates `ktxTexture2_setImageFromStream` to allow setting `faceSlice` to `KTX_FACESLICE_WHOLE_LEVEL`. This allows setting the entire level's data in one call rather having to do a loop setting each slice individually. Fixes: KhronosGroup#792
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
…tire level's data in one call (KhronosGroup#794) This change updates `ktxTexture2_setImageFromStream` to allow setting `faceSlice` to `KTX_FACESLICE_WHOLE_LEVEL`. This allows setting the entire level's data in one call rather having to do a loop setting each slice individually. Fixes: KhronosGroup#792
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates
ktxTexture2_setImageFromStreamto allow settingfaceSliceto-1,This allows setting the entire level's data in one call rather having to do a loop and setting each slice individually.
Fixes: #792