[WIP] Unset the flash chip's WP pin on erase #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code is board dependent, it has to be made more generic (allowing to select the GPIO using command line arguments) for me to be able to merge it. |
|
Yup, that's why it's WIP and I added that comment :-) |
Usually firmware asserts the flash chip's WP pin to protect the its content. Deassert WP during erase/write operations. TODO: probably board specific Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
c0d3z3r0
force-pushed
the
for-upstream/wp_pin
branch
from
49e0dc7
to
0a440f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually firmware pulls the WP pin of the flash chip low to protect the flash chip's content. Set it to high during erase/write.
This was required on a Lenovo ThinkVision P40w-20. Found out by reading Realtek RTD Customer Tool communication during erase. Maybe it's generic? I don't know yet