-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constraints crash #148
Comments
Are you able to reproduce this crash with the Inspector app? Otherwise, could you come up with a sample app so I could debug the issue? |
Unfortunately, I wasn't able to reproduce it :( |
Does your app manipulate constraints of subviews in any way? |
I really want to get it fixed, but I am at a loss where to start. Just doesn't make sense that it crashes only occasionally on a static layout like this. |
I understand, no worries, I know that there is not much information here. I have never experienced this issue either. This is the latest stacktrace:
Would it be possible to add there some extra check:
It is weird because it happens based on stack trace on "endRecording" when nothing actually happens on the view. The crash says that you are setting constraints with some layout guide. What layout guide it is? EDIT:
Please take a look here, it looks like it happens during deallocation. Probably the view or something is already detached but the deallocation triggers constraints update? EDIT2:
EDIT3:
The solution would be probably to avoid constraints update during deallocation :) 🍺 |
Could you reproduce it in a sample project that you can share? Want to make sure I got it right. |
Please try the issue-148 branch. |
I prepared a sample project: Steps:
If you change in |
@Kentzo when do you think you will be able to release your fix? |
Do you need binaries or a tag would suffice? |
I'm using CocoaPods. Are you able to release the new version? |
First of all, thank you for this nice library, I really like it!
From time to time I get this crash from my app:
My app is targeting
macOS 11.0
and I'm using ShortcutRecorder3.3.0
. The last noticed crash was on macOS 12.5.1The text was updated successfully, but these errors were encountered: