Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CliRouter is child of CliRouter is child of ... #84

Closed
MilanPala opened this issue Sep 13, 2019 · 3 comments
Closed

CliRouter is child of CliRouter is child of ... #84

MilanPala opened this issue Sep 13, 2019 · 3 comments

Comments

@MilanPala
Copy link
Contributor

image

@slepic
Copy link
Contributor

slepic commented Sep 24, 2019

I've got the same problem.
I would redefine the problem not CliRouter child of CliRouter, etc.
But rather RouteList child of RouteList, etc...

Ive narrowed the problem to this line:
https://github.com/Kdyby/Console/blob/master/src/DI/ConsoleExtension.php#L218

Where the console extension picks the default routelist and replaces it with new one, but at the same time it appends the routelist to itself.

This causes the router to enter infinite loop.

@slepic
Copy link
Contributor

slepic commented Sep 25, 2019

#85 fixes the problem and even reverts BC break where console.originalRouter service was made no longer available
https://github.com/Kdyby/Console/blob/v2.7.1/src/DI/ConsoleExtension.php#L206

Spamercz added a commit that referenced this issue Sep 30, 2019
fix infinite recursion in router di definition #84
@Spamercz
Copy link
Member

This issue is resolved by this PR #85 @MilanPala reported this was working fix.
Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants