Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37240 - Fix CCV duplicate repo warning #10928

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

m-bucher
Copy link
Contributor

What are the changes introduced in this pull request?

only show duplicate repo warning on CCV publish, if it is actually true.

Considerations taken when implementing this change?

duplicate repo value is usually [] if no duplicates are present.

What are the testing steps for this pull request?

publish CCV without duplicate repos => message should not be there.

@m-bucher m-bucher force-pushed the fix_duplicate_ccv_repo_warning branch from 746d686 to 3a18f07 Compare March 12, 2024 13:07
@m-bucher
Copy link
Contributor Author

@sjha4 this was caused by #10741

Copy link
Member

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @m-bucher ! Ack..Can reproduce and the commit fixes it.

@sjha4 sjha4 merged commit 02fc313 into Katello:master Mar 13, 2024
22 checks passed
@quba42 quba42 deleted the fix_duplicate_ccv_repo_warning branch March 14, 2024 08:16
qcjames53 pushed a commit to qcjames53/katello that referenced this pull request Mar 19, 2024
qcjames53 added a commit that referenced this pull request Mar 19, 2024
* Refs #37148 - Remove removed_widgets override (#10927)

(cherry picked from commit 40a70ce)

* Fixes #35215 - Handle cloned hostgroups in hosts_and_hostgroups_helper (#10894)

(cherry picked from commit e3d46c6)

* Fixes #36979 - Remove cdn_ssl_version setting

This was originally added to allow downgrading the CDN connection
SSL version for compatibility with much older proxy servers. That
should be less of a concern now.

We do still set a value of TLS v1.2 for the min_version, but only
because ruby/openssl#709 prevents using
the system-wide crypto policy for now. In the future, that can be
removed as well, restoring control to the user at the OS level.

(cherry picked from commit 78fcba9)

* Fixes #37277 - Fix ACS randomly failing VCR tests (#10941)

(cherry picked from commit 6d93801)

* Fixes #37240 - Fix CCV duplicate repo warning (#10928)

(cherry picked from commit 02fc313)

---------

Co-authored-by: Jeremy Lenz <jlenz@redhat.com>
Co-authored-by: William Bradford Clark <wclark@redhat.com>
Co-authored-by: Ian Ballou <ianballou67@gmail.com>
Co-authored-by: Markus Bucher <bucher@atix.de>
m-bucher added a commit to ATIX-AG/katello that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants