Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 342/enable horizontal scrolling #419

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sergio-sastre
Copy link
Contributor

@sergio-sastre sergio-sastre commented Nov 13, 2022

This is point 1 from
#342 (comment)

Second point would be an improvement over point one, to be done in a different PR. Therefore, this could be merged without completing point 2.
Unfortunately, not sure when I'll find time for it

step("Click nnHbutton5 in 3LevelNestedScrollView, middle item") {
NestedScrollViewsScreen {
nnHscrollView.scrollToView(nnHbutton5)
nnHbutton5.click()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by implementing point 2 #342 (comment), nnHscrollView.scrollToView(nnHbutton5) would not be needed since it would be done by the autoscroll.

Same for the other horizontalScrollView#scrollToView() calls in other tests of this class

@AzamatCherchesov
Copy link
Collaborator

@sergio-sastre any updates?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants