Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hvac_action attribute stays in "heating" state even if Better Thermostat is turned off #1340

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

Ashpork
Copy link
Contributor

@Ashpork Ashpork commented Apr 20, 2024

Remove check for an empty hvac_action

Motivation:

This is in relation to #1193 , after the changes made previously in this thread were made and 1.5 was released. I still have HVAC_action staying as heating, when the device state is off and the set temp is higher than current temp.

Changes:

Remove a check for the current hvac_action to be none before the rest of the normal logic kicks in.

Related issue (check one):

Checklist (check one):

  • I did not change any code (e.g. documentation changes)
  • The code change is tested and works locally.

Remove check for an empty hvac_action
@KartoffelToby KartoffelToby merged commit 946ab94 into KartoffelToby:master Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hvac_action attribute stays in "heating" state even if Better Thermostat is turned off.
2 participants