Fix failing climate.turn_on issue introduced in version 1.5.0-beta6 #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit b53b564 that went into BT version 1.5.0-beta6 introduced an issue causing the climate.turn_on operation to consistently fail. The problem is due to the fact that HVACMode.HEATING is used in the call of self.async_set_hvac_mode() inside async_turn_on() function instead of HVACMode.HEATING().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit b53b564 that went into BT version 1.5.0-beta6 introduced an issue causing the climate.turn_on operation to consistently fail.
The problem is due to the fact that HVACMode.HEATING is used in the call of self.async_set_hvac_mode() inside async_turn_on() function instead of HVACMode.HEAT.
Motivation: climate.turn_on operation called on BT fails because of a recent commit (b53b564) to 1.5.0-beta6.
Changes: HVACMode.HEAT is now used in the call of self.async_set_hvac_mode() inside async_turn_on() function, instead of the wrong HVACMode.HEATING.
Related issue (check one): #1295
Checklist (check one):
Test-Hardware list (for code changes)
HA Version: 2024.3.2
Zigbee2MQTT Version: 1.36.0
TRV Hardware: Aqara Smart radiator thermostat E1
New device mappings
climate.py