Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Changes:
Related issue (check one):
Checklist (check one):
Test-Hardware list (for code changes)
HA Version:
Zigbee2MQTT Version: 1.33.2-1
TRV Hardware: Moes BRT-100-TRV and Avatto ME167
New device mappings
climate.py
Hello,
Here are a few modifications that I applied to my local home assistant.
Everything is not clean enough to be directly applied to your repo but I wanted to know if you are interested in the feature I added before oing further.
I added two features:
Hybrid calibration mode
I added this feature because I was not happy with the way my TRV handles opening/closing its valve.
Often, when the local temperature was close to the target temp, the valve closed itself to 25%. Because of that, the target temperature took a long time to be reached.
This is annoying because my boiler is controled by HA and will be ON if any of my valves is open.
I also want the local temperature on my TRV to be as closed as possible as my temperature sensor.
Because of that I created a hybrid calibration mode.
The idea is simple:
This allow me to have the desired behavior.
This addition is quite messy as I juste added a new value of 2 to
self.real_trvs[entity_id]["calibration"]
while it was designed to be a boolean.Target temperature step option
My TRV target temperature step is 1°C.
However, with my previous feature, the effective BT accuracy is the accuracy of the temperature sensor.
I added an option to override the temperature step of the TRV to have a better control on the desired temperature in a room.
Error handling
I also added a error catch in the
set_hvac_mode
asI was experiencing some crashed in that function when using the Moes TRV with ZHA.Conclusion
Let me know what you think about those features.
Maybe what I did is not interesting for anyone except me.