Basic Neutrino Oscillation Functionality #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no.jl into basic_oscillation_linalg
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
=========================================
Coverage ? 69.44%
=========================================
Files ? 3
Lines ? 72
Branches ? 0
=========================================
Hits ? 50
Misses ? 22
Partials ? 0 Continue to review full report at Codecov.
|
tamasgal
reviewed
Aug 12, 2020
tamasgal
reviewed
Aug 30, 2020
| import Base | ||
| export transprob, OscillationParameters, PMNSMatrix, Hamiltonian, MatterOscillationMatrices | ||
|
|
||
| # TEMPORARY UNTIL PhysicalConstants.jl GETS UPDATED |
There was a problem hiding this comment.
These three lines are a bit confusing, G_F is overwritten
There was a problem hiding this comment.
Yeah it is not that clean as it could be, but as I wrote in the comment this was expected to survive just a few days. Unfortunately I didn't have the time a.k.a. to finish my PR in the PhysicalConstants project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the title says ;-)