Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the launcher dialog as a shared library #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

giucam
Copy link
Contributor

@giucam giucam commented Feb 9, 2017

This is to be used in the qtcreator plugin instead of the custom dialog.

vkrause added a commit that referenced this pull request Apr 4, 2017
This enables the re-use of some of its widgets in the QtCreator
integration.

Based on pull request #314
@vkrause
Copy link
Contributor

vkrause commented Apr 4, 2017

When reviewing this I found it hard to reason about the dependencies in the launcher code, so I have shuffled the code around a bit and integrated the part of this change creating a shared library for the UI components (see wip/launcher-refactor branch).

Once that is merged we can rebase this change on top and should only be left with the API changes. I'm surprised though that there are no exports added in this change, which classes are actually needed in QtCreator in the end?

vkrause added a commit that referenced this pull request Apr 4, 2017
This enables the re-use of some of its widgets in the QtCreator
integration.

Based on pull request #314
vkrause added a commit that referenced this pull request Apr 4, 2017
This enables the re-use of some of its widgets in the QtCreator
integration.

Based on pull request #314
@giucam
Copy link
Contributor Author

giucam commented Apr 5, 2017

I had forgotten to add the files with the new LauncherDialog class, which is the glue that was missing.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants