Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce support to override alert rule name #234

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

themarcelor
Copy link

Currently, the alert rule is provisioned with a Title that matches the panel title. The Alert constructor function receives a name argument but misleadingly sets that value as the alert rule's Summary instead of AlertRule.Title.

The provisioned dashboard panels can have generic names like "traffic" or "latency", but their corresponding Alert Rules need to have more specific titles, e.g.:

  • my-service traffic alarm
  • my-service latency alarm

Hence, this PR will allow the operator to utilize an alert.name() option.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #234 (bb84610) into master (6867a4a) will decrease coverage by 0.06%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   90.08%   90.03%   -0.06%     
==========================================
  Files          92       92              
  Lines        6941     6945       +4     
==========================================
  Hits         6253     6253              
- Misses        543      547       +4     
  Partials      145      145              
Files Changed Coverage Δ
alert/alert.go 96.39% <0.00%> (-3.61%) ⬇️
📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant