Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node-sass doesn't pick up on SASS _ files #300

Closed
romeboards opened this issue Oct 19, 2018 · 4 comments · Fixed by #1179
Closed

Node-sass doesn't pick up on SASS _ files #300

romeboards opened this issue Oct 19, 2018 · 4 comments · Fixed by #1179

Comments

@romeboards
Copy link
Contributor

No description provided.

@toolness
Copy link
Collaborator

Wait, uh, I'm actually unable to reproduce this on my end using Docker, which is weird... But I definitely have run into weird situations where I'm editing our SASS and the SASS watcher somehow doesn't pick up on the changes--it just seems to happen intermittently and I'm not sure how to reproduce the problem consistently. Blurgh!

@toolness
Copy link
Collaborator

toolness commented Feb 1, 2019

FWIW, I just fixed another funky "dev setup won't notice that some files have changed" issue in 0c2c4a9, which may have mistakenly been attributed to this in the past, I'm not sure.

@toolness
Copy link
Collaborator

Hmm, given that I've been unable to reproduce this, I'm closing this issue. If we encounter it again we can re-open it, preferably with exact steps to reproduce.

@toolness toolness reopened this Apr 12, 2020
@toolness
Copy link
Collaborator

toolness commented Apr 12, 2020 •
edited
Loading

The problem is that node-sass won't notice changes in new files, e.g. if we add a _boop.scss and import it in styles.scss, it won't notice any changes in _boop.scss until we restart the watcher. It looks like this is still an open issue at sass/node-sass#1891.

toolness added a commit that referenced this issue Apr 12, 2020
@toolness
Use node-sass-chokidar. Fixes #300.
57a7609
@toolness toolness mentioned this issue Apr 12, 2020
Merged
toolness added a commit that referenced this issue Apr 12, 2020
@toolness
Use node-sass-chokidar. Fixes #300. (#1179)
d9f6858 
This fixes #300 by using node-sass-chokidar.

I'm not a big fan of what this is doing to our `yarn.lock`, as it seems to have brought in yet another version of chokidar and a few other dependencies we already have, but since it's all on the build side and not in the browser I think it's ok.  Still, we should figure out if there's an easy way to clean up the `yarn.lock` at some point, so I've filed #1180 to address it later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use node-sass-chokidar JustFixNYC/tenants2
2 participants
@toolness @romeboards