Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install from Published Chart #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Install from Published Chart #37

wants to merge 1 commit into from

Conversation

asergeant01
Copy link
Contributor

Pull Request Template

Description

Enables the ability to install and enc from a published chart

Fixes #36

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

  • Python Version: 3.9
  • Vault Version: Vault 1.6.2+prem

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Mentions:

@Just-Insane

@asergeant01
Copy link
Contributor Author

asergeant01 commented Apr 16, 2021 •
edited
Loading

@Just-Insane I opened this PR just so you can take a look.

I've tested it by pulling a published chart from a private artifactory instance. Currently it works on an either or scenerio.
e.g. helm vault install mychart repo/mychart or helm vault install mychart repo/mychart -f myoverride_values.yaml
In the latter example it wouldn't decrypt both, as it would assume you can override any attributes you want decrpyted in the supplied yaml file.

It does however work for manual sets.
e.g. helm vault install mychart repo/mychart --set http.port=8080 etc.

Hopefully this is useful for you. I'm being forced to get a move on with work so i dont have the bandwidth to write up the docs and tests. Hopefully this can be a starting point however.

@Just-Insane
Copy link
Owner

Awesome, I can write up some documentation and tests.

Thanks for all the work on this!

@asergeant01
Copy link
Contributor Author

@Just-Insane No problem at all. This article might help you setup github pages to serve as a helm repo to publish your test chart to.

https://medium.com/@mattiaperi/create-a-public-helm-chart-repository-with-github-pages-49b180dbb417

@asergeant01 asergeant01 force-pushed the install-from-published-chart branch 2 times, most recently from b8589f8 to 8eb8456 Compare May 4, 2021 12:06
@asergeant01 asergeant01 force-pushed the install-from-published-chart branch from 8eb8456 to ea56f44 Compare May 4, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encode and decode published charts
2 participants
@asergeant01 @Just-Insane