Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nbclassic while updating the static path #141

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

echarles
Copy link
Collaborator

@echarles echarles commented Sep 10, 2022

Fixes jupyter/nbclassic#140

This PR ensure that jupyter_nbextensions_configurator can also run on the latest nbclassic.

@echarles
Copy link
Collaborator Author

While this works fine when the user clicks on the menu to show the configurator page (http://localhost:8888/tree?#nbextensions_configurator), it does not solve the issue when the user directly types in his browser http://localhost:8888/nbextensions

This can however be merged as a step towards a more complete solution.

@echarles
Copy link
Collaborator Author

This PR is ready for review.

@kevingoldsmith
Copy link

LGTM

@echarles
Copy link
Collaborator Author

@juhasch Have you bandwidth to review and help with this? Anyone else interested to have a look? Thx!

@echarles
Copy link
Collaborator Author

I am adding @damianavila as potential reviewer of this PR (just seeing Damian is part of this jupyter-contrib github organisation).

Happy to answer any question on these changes which are fully backwards compatible.

@damianavila
Copy link
Member

@juhasch would be a better reviewer than me since I have not been connected with the codebase for a loooong time.

Juergen, WDYT about this one? I presume this one would also need a release as well...

@echarles
Copy link
Collaborator Author

Thx @damianavila for the comment.

@juhasch Do you have any question on this change. It is working fine on my env for notebook 6.4.x, 6.5.x and nbclassic.

@juhasch
Copy link
Contributor

juhasch commented Nov 7, 2022

Sorry for replying so late, I am mostly off Github currently. Let me take a look what to do.

@juhasch juhasch merged commit bd13c87 into Jupyter-contrib:master Nov 13, 2022
@juhasch
Copy link
Contributor

juhasch commented Nov 13, 2022

Thank you for your patience @echarles

@echarles
Copy link
Collaborator Author

Super! Thx you for taking time to review and merge @juhasch

I wonder what are the plans for a release? Would you like me to open an issue for that?

@juhasch
Copy link
Contributor

juhasch commented Nov 13, 2022

We should do a release quickly, I think. If you open a PR that would be great.

@echarles
Copy link
Collaborator Author

We should do a release quickly, I think. If you open a PR that would be great.

I am not sure what content the PR should have. Do I have to just bump the version?

@juhasch
Copy link
Contributor

juhasch commented Nov 13, 2022

Just bump the version and update the readme (changes section). That should be enough.

@echarles
Copy link
Collaborator Author

@damianavila
Copy link
Member

Folks, created #146 to further discuss adding more maintainers to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error using jupyter_nbextensions_configurator with nbclassic
4 participants