Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nowarn=:allexcept and except=[f, g, h, ...] options to @check and check #38

Merged
merged 3 commits into from
Sep 17, 2019
Merged

Add nowarn=:allexcept and except=[f, g, h, ...] options to @check and check #38

merged 3 commits into from
Sep 17, 2019

Conversation

DilumAluthge
Copy link
Contributor

@DilumAluthge DilumAluthge commented Sep 16, 2019

Pull request #32 added the ability to tell @check/check to throw an error if any warnings occur inside any function.

This pull request extends this functionality by adding the ability to tell @check/check to throw an error if any warnings occur inside any function EXCEPT those functions listed in the except array.

Before this pull request

  1. @check f(x) nowarn=[g]: throw an error if any warnings occur inside the function g
  2. @check f(x) nowarn=:all: throw an error if any warnings occur inside any functions

After this pull request

  1. @check f(x) nowarn=[g]: throw an error if any warnings occur inside the function g
  2. @check f(x) nowarn=:all: throw an error if any warnings occur inside any functions
  3. @check f(x) nowarn=:allexcept except=[h]: throw an error if any warnings occur inside any functions EXCEPT the function h

@DilumAluthge
Copy link
Contributor Author

Travis failures on Julia 1.2 and nightly are known (issue #31)

@pfitzseb pfitzseb closed this Sep 16, 2019
@pfitzseb pfitzseb reopened this Sep 16, 2019
@pfitzseb
Copy link
Member

The nowarn arg is redundant when except is supplied, or am I missing something?

@DilumAluthge
Copy link
Contributor Author

The nowarn arg is redundant when except is supplied, or am I missing something?

Yeah that’s a good point. So if the user supplies except, should we just ignore the value of nowarn, whatever that value is?

@DilumAluthge
Copy link
Contributor Author

DilumAluthge commented Sep 17, 2019

Alright, I've updated the code. If except is nonempty, I ignore the value of nowarn.

@pfitzseb pfitzseb merged commit f30cef5 into JunoLab:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants