Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added coco evaluation code #34

Merged
merged 2 commits into from
Jul 23, 2024
Merged

added coco evaluation code #34

merged 2 commits into from
Jul 23, 2024

Conversation

omkaar718
Copy link
Contributor

Added code to evaluate the models on COCO val set. Instructions added in the readme under 'Evaluation on COCO dataset'.

@JunkyByte
Copy link
Owner

Hello! Thanks again @omkaar718 for providing this.
Everything looks good to me but I would like to keep the same signature for the inference() function so that other parts do not need to move. I guess the scores_bbox can be saved in the if provided by self.save_state so that you access them as needed. The eval method will need to access these manually.


if self.save_state:
self._img = img
self._yolo_res = results
self._tracker_res = (bboxes, ids, scores)
self._keypoints = frame_keypoints

return frame_keypoints
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here just return the keypoints, and on line 272 save the scores_bbox when self.save_state.


img = cv2.cvtColor(img, cv2.COLOR_BGR2RGB)
# print('Img read, ', img.shape)
frame_keypoints, conf_score = model.inference(img)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

access the model scores_bbox directly

Copy link
Owner

@JunkyByte JunkyByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

@JunkyByte JunkyByte merged commit 957efcc into JunkyByte:main Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants