Performance improvement in channel processing #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performance of the channel processing.
It made faster by 270x in the function
getChannel
and 23x in the functionapplyChannel
than the current version on my computer.The main changes:
getChannel
: generate CIR by matrix operation without for-loop.applyChannel
: process the time-varying convolution in different functions in order to get optimization of the for-loop by the Julia compiler.p.s. thank you very much for creating this wonderful package!!