Clear confusion about geomagnetic field vector #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input variables to these functions are date (i.e. year), radius (i.e. Z), latitude, and longitude (i.e. X and Y). There's no mention that the components of the returned geomagnetic field vector are X, Y, Z. While this might be an obvious convention, I had no idea and assumed that the order of the components would be the same as the order of the input variables to these functions (i.e. Z, X, Y). I tried to "fix" that with that tiny notation in the parenthesis, but maybe you have a better idea. As a side note, it might be good to add functions for the magnetic components listed for example [here](https://www.geomag.nrcan.gc.ca/mag_fld/comp-en.php).
|
Hi @yakir12 ! Sorry for the delay! Perfect, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input variables to these functions are date (i.e. year), radius (i.e. Z), latitude, and longitude (i.e. X and Y). There's no mention that the components of the returned geomagnetic field vector are X, Y, Z. While this might be an obvious convention, I had no idea and assumed that the order of the components would be the same as the order of the input variables to these functions (i.e. Z, X, Y). I tried to "fix" that with that tiny notation in the parenthesis, but maybe you have a better idea.
As a side note, it might be good to add functions for the magnetic components listed for example here.