Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use metaprogramming to generate out-of-place methods #887

Merged
merged 6 commits into from
Oct 13, 2024

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Oct 13, 2024

All Krylov methods are concerned but I only want to use it for block_gmres now.
I want to check the impact on precompilation time for the other methods.

Update: No performance reduction on non-Block Krylov methods. 👍

Copy link
Contributor

github-actions bot commented Oct 13, 2024

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
LLSModels.jl
LinearSolve.jl
Percival.jl
RipQP.jl

@amontoison amontoison merged commit f5fbae9 into JuliaSmoothOptimizers:main Oct 13, 2024
28 of 30 checks passed
@amontoison amontoison deleted the metaprog_timemax branch October 13, 2024 18:16
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 51.28205% with 19 lines in your changes missing coverage. Please review.

Project coverage is 94.93%. Comparing base (b68a403) to head (f5bb734).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/krylov_solve.jl 50.00% 17 Missing ⚠️
src/block_krylov_solvers.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
+ Coverage   94.64%   94.93%   +0.28%     
==========================================
  Files          44       44              
  Lines        8514     8206     -308     
==========================================
- Hits         8058     7790     -268     
+ Misses        456      416      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant