Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing deprecation for fetchMsgUpThis #1053

Closed
dehann opened this issue Dec 16, 2020 · 2 comments · Fixed by #1079
Closed

Missing deprecation for fetchMsgUpThis #1053

dehann opened this issue Dec 16, 2020 · 2 comments · Fixed by #1079

Comments

@dehann
Copy link
Member

dehann commented Dec 16, 2020

What is the replacement function from v0.16 for fetchMsgUpThis?

Hi @Affie, I think you removed this function perhaps?

#TODO function is currently broken as getUpMsgs does not exist, possibly deprecated?

#TODO function is currently broken as getUpMsgs does not exist, possibly deprecated?
# DF, I did some digging and got this far
# v0.14 @deprecate getUpMsgs(x...) getMsgsUpThis(x...)
#       @deprecate getMsgsUpThis(x...) getMsgUpThis(x...)
#         getMsgUpThis(cdat::BayesTreeNodeData) = fetch(getMsgUpChannel(cdat))
# v0.16 @deprecate getMsgUpThis(x...;kw...) fetchMsgUpThis(x...;kw...)
# fetchMsgUpThis was never properly deprecated
@dehann
Copy link
Member Author

dehann commented Dec 28, 2020

I think the replacing function might be IIF.getMessageBuffer(cliq).upTx

@Affie
Copy link
Member

Affie commented Jan 14, 2021

Hi @dehann, As far as I remember the decision was to move the fetch csm to the attic without deprecation.
IIF.getMessageBuffer(cliq).upTx doesn't sound correct (and its not in use as far as I remember). Is it not closer to IIF.getMessageBuffer(cliq).upRx or was it the message that was sent out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants