Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CSM debug tools (overcome missing deprecations) #667

Open
dehann opened this issue Dec 24, 2020 · 1 comment
Open

Test CSM debug tools (overcome missing deprecations) #667

dehann opened this issue Dec 24, 2020 · 1 comment

Comments

@dehann
Copy link
Member

dehann commented Dec 24, 2020

EDIT: part of the problem is we removing Graphs.jl which removes drawing utils, so basically we just need an end-to-end test of IIF.animateCSMSideBySide with all the necessary deprecations. The types and names are all slightly changed, so yes just a solid round of deprecations required all round here.


More breaking type changes between Caesar / IIF / FSM that were not properly deprecated. The type has been changed to NamedTuple:

julia> typeof(hists)
Dict{Int64,Array{NamedTuple{(:timestamp, :id, :f, :csmc),Tuple{Dates.DateTime,Int64,Function,CliqStateMachineContainer}},1}}

Some of the debug tools from Caesar call upstream through IIF into FSM

https://github.com/JuliaRobotics/IncrementalInference.jl/blob/4e9f088f336618377aa8481ee9068c72f1f41f17/src/TreeDebugTools.jl#L757

But FSM wants the old Tuple type:

function animateStateMachineHistoryIntervalCompound(hists::Dict{Symbol, Vector{Tuple{DateTime, Int, <: Function, T}}};

As well as Dict of either Int or Symbol.

We should add animateCSM the tests to make sure this does not happen again. I ask for help on getting broader test coverage please, especially if type changes are made.

cc @Affie

@dehann
Copy link
Member Author

dehann commented Dec 24, 2020

@dehann dehann changed the title More CSM debug tools broken (missing deprecations, again) Test CSM debug tools (overcome missing deprecations) Dec 26, 2020
@dehann dehann transferred this issue from JuliaRobotics/IncrementalInference.jl Dec 26, 2020
@dehann dehann added this to the v0.0.x milestone Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant