[geotiff] build with libtiff 4.5 #6929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to do PROJ_jll first (edit: see #6930), since that also has a libtiff dependency, as well as a geotiff dependency. dependencies = [
Dependency("PROJ_jll"; compat="~900.200.100"),
Dependency("Libtiff_jll"; compat="4.5.1"),
Dependency("LibCURL_jll"; compat="7.73,8"),
]EDIT: done |
This was referenced Jun 22, 2023
visr
added a commit
to visr/General
that referenced
this pull request
Jun 22, 2023
Looks like the [upgrade](JuliaPackaging/Yggdrasil#6924) from libtiff 4.4 to 4.5 was [breaking](JuliaBinaryWrappers/Libtiff_jll.jl@fddff20#diff-248757425c80d519c91e1be718766832fdd989ae7837c5c4b6e64f95931a4757) at least on Windows. Is this the right way to avoid breaking JLLs that depend directly on Libtiff_jll? Ref JuliaPackaging/Yggdrasil#6929
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the upgrade from libtiff 4.4 to 4.5 was breaking at least on Windows.
Reported in JuliaGeo/GDAL.jl#158
Also addresses one case of #6857 in an effort to get nightly support working again (JuliaGeo/GDAL.jl#152).