Update TempestRemap deps #5396
Closed
Update TempestRemap deps #5396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Aug 31, 2022
| julia_compat="1.7", | ||
| julia_compat="1.8", |
There was a problem hiding this comment.
🤷🏻♂️, I've never done this before, so probably not?
There was a problem hiding this comment.
Yeah, I don't think this is necessary at all
giordano
reviewed
Aug 31, 2022
| julia_compat="1.7", | ||
| julia_compat="1.8", |
There was a problem hiding this comment.
Yeah, I don't think this is necessary at all
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the TempestRemap deps to be compatible with the latest . Refs:
We need this to update ClimaCoreTempestRemap to julia 1.8. I think this is the only outstanding blocker for updating. cc @simonbyrne
I've never done this before, and I'm almost certainly doing this wrong, but I'll update as I figure out how to do this correctly.