Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency in doc #114

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix inconsistency in doc #114

wants to merge 2 commits into from

Conversation

pizhn
Copy link
Collaborator

@pizhn pizhn commented Aug 23, 2021

No description provided.

@pizhn
Copy link
Collaborator Author

pizhn commented Aug 24, 2021

Just renamed LS1 to LocalSearch and fixed some docs, will that be confusing because it sounds just like a local optimization method but its actually global.

@codecov-commenter
Copy link

Codecov Report

Merging #114 (83fa612) into master (07e70ad) will not change coverage.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   70.69%   70.69%           
=======================================
  Files          37       37           
  Lines        2962     2962           
=======================================
  Hits         2094     2094           
  Misses        868      868           
Impacted Files Coverage Δ
src/Nonconvex.jl 100.00% <ø> (ø)
src/algorithms/mts.jl 95.68% <88.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e70ad...83fa612. Read the comment docs.

@mohamed82008
Copy link
Member

Please move the renaming to NonconvexSearch then update the docs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants