Avoid impossible unionall normalization #42003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the unionall bounds are inconsistent with the wrapper's bound, avoid throwing due to an impossible type instantiation.
|
bugfix? (and thus should be backported?) |
|
I'd say yes. |
martinholters
added
backport 1.6
|
I am not sure it is to be expected that apply type is infailable. There seem like other reasons (earlier) that it could also fail? |
|
True, but that there are types julia> foo(x) = abs(x::(Complex{T} where String<:T<:String))
foo (generic function with 1 method)
julia> code_typed(foo, (Any,))
ERROR: TypeError: in Complex, in T, expected T<:Real, got Type{String}
Stacktrace:
[1] argtypes_to_type
[...]With this PR, inference succeeds. |
This was referenced Aug 27, 2021
KristofferC
pushed a commit
that referenced
this pull request
Sep 2, 2021
If the unionall bounds are inconsistent with the wrapper's bound, avoid throwing due to an impossible type instantiation. (cherry picked from commit b5b0684)
KristofferC
pushed a commit
that referenced
this pull request
Sep 3, 2021
If the unionall bounds are inconsistent with the wrapper's bound, avoid throwing due to an impossible type instantiation. (cherry picked from commit b5b0684)
KristofferC
pushed a commit
that referenced
this pull request
Sep 6, 2021
If the unionall bounds are inconsistent with the wrapper's bound, avoid throwing due to an impossible type instantiation. (cherry picked from commit b5b0684)
DilumAluthge
removed
the
merge me
KristofferC
removed
backport 1.6
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
If the unionall bounds are inconsistent with the wrapper's bound, avoid throwing due to an impossible type instantiation.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
If the unionall bounds are inconsistent with the wrapper's bound, avoid throwing due to an impossible type instantiation.
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
If the unionall bounds are inconsistent with the wrapper's bound, avoid throwing due to an impossible type instantiation. (cherry picked from commit b5b0684)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cousin of #41976, fixing the second case of #41908 (comment).