Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webio_serve(::Mux.App) #379

Merged
merged 2 commits into from
Jan 8, 2020
Merged

webio_serve(::Mux.App) #379

merged 2 commits into from
Jan 8, 2020

Conversation

cstjean
Copy link
Contributor

@cstjean cstjean commented Jan 6, 2020

The docstring says:

  webio_serve(app, port=8000)

  Serve a Mux app which might return a WebIO node.

but, frustratingly, it does not currently accept a Mux.app. This PR trivially fixes this issue.

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #379 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #379      +/-   ##
========================================
- Coverage    62.1%    62%   -0.11%     
========================================
  Files          16     16              
  Lines         599    600       +1     
========================================
  Hits          372    372              
- Misses        227    228       +1
Impacted Files Coverage Δ
src/providers/mux.jl 9.52% <0%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7585c5...3fe640d. Read the comment docs.

@shashi
Copy link
Member

shashi commented Jan 8, 2020

Thanks!

@shashi shashi merged commit 79de659 into JuliaGizmos:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants