Don't check the Window, check the Page #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JobJob
changed the title
|
Can someone make a new release? I'm scared 🙀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JuliaGizmos/WebIO.jl#357 and JuliaGizmos/Interact.jl#344
I don't know why exactly, I'd like to know though if anyone knows the difference between
active(comm.window)andactive(comm.window.content)? Is there a possibility of deadlock or some other funny business ifactive(comm.window)is called from two different tasks/threads?Nonetheless I think we should probably just merge this since:
a) this PR just restores the code from before the WebIO integration was moved here (and was probably just accidentally changed then)
b) WebIO, and thus PlotlyJS, Interact, etc. are somewhat broken in Blink without this for more complex UIs (see linked issues)
(fyi @travigd)